🐛 Fixed exhausts on predefined actors. #3205
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: The trains on Train Valley now continuously produce smoke until you activate them. Fix: shut down the particle emitters when spawning (unified code with custom-particles)
|
👍 |
The code was introduced by myself 4 years ago in c843544 - it would only work correctly for actors spawned by user (Origin::SAVEGAME) . - it would have no effect for preloaded actors as those are either already spawned at that point, or not installed.
Broken by myself 1 month ago in b3ffea4 - savegames began using the new "bundle-qualified" syntax, i.e. "mybundle.zip:myactor.truck" - but when loading and detecting preloaded actors, the bundlename was not stripped from the filename, causing none to be found.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: The trains on Train Valley now continuously produce smoke until you activate them.
Fix: shut down the particle emitters when spawning (unified code with custom-particles)
UPDATE: Also fixed savegame issues that manifested on this terrain: https://discord.com/channels/136544456244461568/189904947649708032/1323326091313545300